Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(UI): Add Larger Callout to the Short Description #4049

Merged

Conversation

pertrai1
Copy link
Contributor

Description:

The short description now has more of a visual separation that allows it to be identified quicker when scanning the page and wanting to find out as quickly as possible the description for the given API.


Screenshot
docs-short-description-callout

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.783% when pulling 84f42f3 on pertrai1:docs-short-description-ui into 040ec2f on ReactiveX:master.

@niklas-wortmann
Copy link
Member

Basically this looks good. I will do some manual tests and give you feedback afterwards

@benlesh
Copy link
Member

benlesh commented Aug 27, 2018

ping @jwo719

Copy link
Member

@niklas-wortmann niklas-wortmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@niklas-wortmann niklas-wortmann merged commit ad6ee3b into ReactiveX:master Aug 27, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Sep 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants